fix: address post-merge review findings (#876, #900, #875)#963
Merged
bradygaster merged 5 commits intodevfrom Apr 12, 2026
Merged
fix: address post-merge review findings (#876, #900, #875)#963bradygaster merged 5 commits intodevfrom
bradygaster merged 5 commits intodevfrom
Conversation
- Add YAML value escaping helper for skill metadata - Replace catch(err: any) with catch(err: unknown) + narrowing - Add type guards to replace unsafe type assertions - Standardize deprecation messages on `gh copilot` - Fix unsafe exports type cast in cross-package test Closes #924, #925, #926 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster
added
the
skip-version-check
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up fixes after post-merge review feedback, focused on safer error handling and standardizing deprecation messaging in the Squad CLI, with a corresponding changeset.
Changes:
- Replace
catch (err: any)withcatch (err: unknown)and add basic message narrowing. - Add standardized deprecation warnings directing users to
gh copilotforsquad startandsquad rc. - Add a changeset for the CLI release.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/squad-cli/src/cli/core/init.ts | Switch catch typing to unknown and narrow error message before calling fatal(). |
| packages/squad-cli/src/cli/commands/plugin.ts | Switch catch typing to unknown and narrow error message for marketplace browse failures. |
| packages/squad-cli/src/cli-entry.ts | Print deprecation warnings for start and rc, directing users to gh copilot. |
| .changeset/review-findings-fix.md | Adds a changeset entry for the CLI release. |
| '@bradygaster/squad-cli': patch | ||
| --- | ||
|
|
||
| fix: address post-merge review findings — YAML escaping, type safety, deprecation messages |
There was a problem hiding this comment.
The changeset summary mentions “YAML escaping” and “type safety”, but this PR (per diff) only updates catch typing/narrowing and adds deprecation messaging. Please update the changeset text to accurately reflect the changes being released to avoid misleading changelog entries.
Contributor
There was a problem hiding this comment.
Updated the changeset summary in d32b744 to accurately reflect what this PR contains: catch unknown narrowing and deprecation warnings for start/rc commands. Removed the misleading "YAML escaping" reference (those were insider-only changes that were dropped from this cherry-pick).
…scaping reference) Agent-Logs-Url: https://github.com/bradygaster/squad/sessions/54f41407-61bf-4977-85b7-572341c47b62 Co-authored-by: bradygaster <41929050+bradygaster@users.noreply.github.com>
This was referenced Apr 12, 2026
tamirdresher
pushed a commit
that referenced
this pull request
Apr 21, 2026
* fix: address post-merge review findings (#876, #900, #875) - Add YAML value escaping helper for skill metadata - Replace catch(err: any) with catch(err: unknown) + narrowing - Add type guards to replace unsafe type assertions - Standardize deprecation messages on `gh copilot` - Fix unsafe exports type cast in cross-package test Closes #924, #925, #926 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: add changeset for review findings fix Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: trigger CI Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore(.squad): EECOM history — PR #942 rebase learnings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: update changeset to accurately reflect PR changes (drop YAML escaping reference) Agent-Logs-Url: https://github.com/bradygaster/squad/sessions/54f41407-61bf-4977-85b7-572341c47b62 Co-authored-by: bradygaster <41929050+bradygaster@users.noreply.github.com> --------- Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased cherry-pick of tamirdresher's fix from PR #942 (originally based on insider, retargeted to dev).
Applies only the changes relevant to dev:
Dropped insider-only changes (skill.ts YAML escaping, cross-package-exports.test.ts type safety) since those files don't exist on dev.
Closes #924, #925, #926
Supersedes #942
Original author: @tamirdresher
Original commits: 35dd824, 489c73b, 4aa6c4e