Skip to content
This repository was archived by the owner on Feb 16, 2018. It is now read-only.

Conversation

@jjh42
Copy link

@jjh42 jjh42 commented Jun 5, 2013

with vidoe streaming starting with an incomplete header (as
seems to happen with my drone).

  • Added tests and travis.ci support.

with vidoe streaming starting with an incomplete header (as
seems to happen with my drone).

- Added tests and travis.ci support.
@jjh42
Copy link
Author

jjh42 commented Jun 6, 2013

@bsbc review.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be clearer to specify x, the 'number of frames' you want to read, then it would be clear that test considers 3 out of x misaligned_frames acceptable

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not exactly sure how many frames are in there. i'm reading from a file. i just know that a couple of frames misaligned is normal.

@bsbc
Copy link

bsbc commented Jun 6, 2013

jonny, as much as i can tell this looks ok

On Jun 5, 2013, at 5:23 PM, Jonathan Hunt notifications@github.com wrote:

@bsbc review.


Reply to this email directly or view it on GitHub.

jjh42 added a commit that referenced this pull request Jun 6, 2013
Fixes need to work with ARDrone 2.0 including deal
@jjh42 jjh42 merged commit b95c6c9 into master Jun 6, 2013
@jjh42 jjh42 deleted the first-attempt branch June 6, 2013 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants