SUR-358 - Force-UI component issues and Improvements#215
Merged
vrundakansara merged 15 commits intodevfrom Dec 17, 2024
Merged
Conversation
text, icon size and alignment and colors
font styles
jaieds
changed the title
vrundakansara
requested changes
Dec 17, 2024
| disabled?: boolean; | ||
| children: ReactNode; | ||
| size: 'sm' | 'md' | 'lg'; | ||
| size: 'sm' | 'md'; |
Contributor
There was a problem hiding this comment.
Are we deprecating lg size?
Contributor
Author
There was a problem hiding this comment.
Size lg is not on the Figma mockup final design page. Maybe previously we followed in progress Figma. I've also added the backward compatibility for the size lg.
vrundakansara
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Types of changes
How has this been tested?
Checklist: