Skip to content

Comments

SUR-370, SRML-64 - Date Picker component issues and improvements#234

Merged
jaieds merged 7 commits intostagingfrom
component-improvement/date-picker
Dec 30, 2024
Merged

SUR-370, SRML-64 - Date Picker component issues and improvements#234
jaieds merged 7 commits intostagingfrom
component-improvement/date-picker

Conversation

@jaieds
Copy link
Contributor

@jaieds jaieds commented Dec 30, 2024

Description

  • Added a new prop to set the current value.
  • Fix crashing while selecting year.
  • Improved DatePicker component initial value logic.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@jaieds jaieds changed the title SUR-370 - Date Picker component issues and improvements SUR-370, SRML-64 - Date Picker component issues and improvements Dec 30, 2024
Copy link
Contributor

@ravindrakele ravindrakele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested and good to go!

@jaieds jaieds merged commit 631d0e7 into staging Dec 30, 2024
2 checks passed
@jaieds jaieds deleted the component-improvement/date-picker branch December 30, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants