Skip to content

Comments

SRML-102 - Select and LineChart Component improvement and fixes#245

Merged
vrundakansara merged 17 commits intodevfrom
component-improvements
Jan 9, 2025
Merged

SRML-102 - Select and LineChart Component improvement and fixes#245
vrundakansara merged 17 commits intodevfrom
component-improvements

Conversation

@jaieds
Copy link
Contributor

@jaieds jaieds commented Jan 8, 2025 •
edited
Loading

Description

- Improvement: Optimized the Select component item search logic and reorganized props for improved usability.
- Improvement: Added a vertical dashed line feature to the LineChart.
- Fixed: LineChart component Tooltip does not show the required information.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@jaieds jaieds requested a review from vrundakansara January 8, 2025 15:17
@vrundakansara vrundakansara merged commit a172a30 into dev Jan 9, 2025
4 checks passed
@vrundakansara vrundakansara deleted the component-improvements branch January 9, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrundakansara vrundakansara vrundakansara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaieds @vrundakansara