Skip to content

Comments

SUR-387 - Added Hamburger menu component#249

Merged
vrundakansara merged 19 commits intodevfrom
hamburger-menu
Jan 27, 2025
Merged

SUR-387 - Added Hamburger menu component#249
vrundakansara merged 19 commits intodevfrom
hamburger-menu

Conversation

@jaieds
Copy link
Contributor

@jaieds jaieds commented Jan 21, 2025

Description

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@jaieds jaieds changed the title Added Hamburger menu component SUR-387 - Added Hamburger menu component Jan 21, 2025
Copy link
Contributor

@ravindrakele ravindrakele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need figma design to review further, We can add option to disable the animation also.

For now, Looks good! ✅ Approved!

@vrundakansara vrundakansara merged commit 3b4854e into dev Jan 27, 2025
6 checks passed
@vrundakansara vrundakansara deleted the hamburger-menu branch January 27, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants