Skip to content

Comments

SUR-384 - Added - show active preset of datepicker#254

Merged
jaieds merged 6 commits intodevfrom
datepicker-fix
Jan 31, 2025
Merged

SUR-384 - Added - show active preset of datepicker#254
jaieds merged 6 commits intodevfrom
datepicker-fix

Conversation

@ravindrakele
Copy link
Contributor

Description

Demo - https://d.pr/v/kdIvjr
Fix - Show active in preset with background of Date picker.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

Copy link
Contributor

@jaieds jaieds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working some times.

Screencast: https://d.pr/v/ibxICO

@ravindrakele
Copy link
Contributor Author

Not working some times.

Screencast: https://d.pr/v/ibxICO

Issue was related to default preset time for last 7 days and 30 days.
Issue is fixed now. Can you please re-review?

Thanks! ✌🏻

@ravindrakele ravindrakele requested a review from jaieds January 29, 2025 15:25
Copy link
Contributor

@vrundakansara vrundakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog @ravindra114

@ravindrakele
Copy link
Contributor Author

Add changelog @ravindra114

Added changelog, Thanks ✌🏻

Copy link
Contributor

@jaieds jaieds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Working now.

https://d.pr/v/ByR9Zn

Co-authored-by: Jaied Al Sabid <87969327+jaieds@users.noreply.github.com>
@jaieds jaieds merged commit a971f7b into dev Jan 31, 2025
4 checks passed
@jaieds jaieds deleted the datepicker-fix branch January 31, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants