Skip to content

Comments

Component improvements and fixes#267

Merged
vrundakansara merged 20 commits intobrainstormforce:stagingfrom
jaieds:component-improvements
Mar 4, 2025
Merged

Component improvements and fixes#267
vrundakansara merged 20 commits intobrainstormforce:stagingfrom
jaieds:component-improvements

Conversation

@jaieds
Copy link
Contributor

@jaieds jaieds commented Mar 4, 2025

Description

- Improvement - Adjusted the ring width and padding of the Radio Button component.
- Improvement - Added shadow to the disabled switch component for better visual consistency.
- Improvement - Add box-shadow to the Button component.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

Copy link
Contributor

@vrundakansara vrundakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaieds we do not need to handle any backward compatibility here, right?

@jaieds
Copy link
Contributor Author

jaieds commented Mar 4, 2025

@jaieds we do not need to handle any backward compatibility here, right?

@vrundakansara, Yes. There are only some style changes and removed memos from the select component. We do not need to handle any backward compatibility.

@vrundakansara vrundakansara merged commit 1d02418 into brainstormforce:staging Mar 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants