Searchbox component issues and improvements#275
Searchbox component issues and improvements#275vrundakansara merged 24 commits intobrainstormforce:devfrom
Conversation
- Update story.
- Add focus-within styles for primary and secondary variants - Update disabled state to use outline instead of border - Improve visual feedback for different input states
- Add `clearSearchOnClick` prop to optionally clear search term - Implement focus handling to open dropdown when input is not empty - Enhance SearchBoxItem with click and accessibility improvements - Add tabindex and role for better keyboard navigation - Utilize `callAll` utility for combining multiple click handlers
…bility - Implement list navigation using Floating UI's useListNavigation - Add keyboard interactions for dropdown opening and item selection - Convert SearchBoxItem to a button for better accessibility - Integrate FloatingFocusManager for improved focus management - Add active state highlighting for list items - Remove unused imports and simplify component logic
- After pressing arrow down - After pressing arrow up
jaieds
changed the title
jaieds
force-pushed
the
searchbox-component/improvement
branch
from
edbcf0b to
c4f8675
Compare
- Add className prop to the Empty component
ravindrakele
left a comment
ravindrakele
left a comment
There was a problem hiding this comment.
I am trying to see the search results, but I think its not working.
Can we add a story for working searchbox (manually) ?
|
sizes not working for Ghost variant, this could a story issue (not from component) |
|
@ravindra114, I didn't find any issue. Somehow, after I pushed changes on the remote repository it forked the force-ui repository and because of that changes are not reflecting on your end. |
|
https://d.pr/i/hSl0ku <- minor padding issue https://d.pr/i/fJ4wKd <- gap seems is different for sm variant. https://d.pr/i/wtPbzV <- button background color @jaieds only this fixes is need, rest looks good! |
…jaieds/force-ui into searchbox-component/improvement
|
@ravindra114, all issues have been resolved except for the gap. The gap in the actual implementation doesn’t look promising, so I’ve set a suitable value for it. |
3 participants
Description
Screenshots
Types of changes
How has this been tested?
Checklist: