Skip to content

Comments

SUR-382 - Added number and icon variant for completed step#277

Merged
vrundakansara merged 7 commits intodevfrom
progress-steps-fix
Mar 14, 2025
Merged

SUR-382 - Added number and icon variant for completed step#277
vrundakansara merged 7 commits intodevfrom
progress-steps-fix

Conversation

@ravindrakele
Copy link
Contributor

@ravindrakele ravindrakele commented Mar 11, 2025

Description

[updated] https://d.pr/i/uoBFIk

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@ravindrakele ravindrakele changed the base branch from master to dev March 11, 2025 12:21
@ravindrakele ravindrakele marked this pull request as ready for review March 11, 2025 12:22
Copy link
Contributor

@jaieds jaieds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to create this variation?

https://d.pr/i/EnD45R

@ravindrakele
Copy link
Contributor Author

Is it possible to create this variation?

https://d.pr/i/EnD45R

Yes, check https://d.pr/i/iA3ogi

@ravindrakele
Copy link
Contributor Author

@jaieds https://d.pr/i/uoBFIk

You can use like this, added a story also.

Copy link
Contributor

@jaieds jaieds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravindra114 Add change log

Copy link
Contributor

@jaieds jaieds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravindra114, Please check why tests are failing and resolve those.

@vrundakansara vrundakansara merged commit 1f0c476 into dev Mar 14, 2025
4 checks passed
@vrundakansara vrundakansara deleted the progress-steps-fix branch March 14, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants