Skip to content

Comments

Tabs and Area chart component improvements#285

Merged
vrundakansara merged 3 commits intodevfrom
fixes-and-improvements
Mar 24, 2025
Merged

Tabs and Area chart component improvements#285
vrundakansara merged 3 commits intodevfrom
fixes-and-improvements

Conversation

@jaieds
Copy link
Contributor

@jaieds jaieds commented Mar 21, 2025

Description

- Improvement - Introduced the `areaChartWrapper` prop in the AreaChart component to allow for better customization options.
- Improvement - Removed the group selector from the Tabs component to simplify style overrides.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

jaieds added 3 commits March 20, 2025 16:10
- Colors will inherit from it's parent. So not required here.
- Override styles easily.
 - Added `areaChartWrapperProps` to allow customization of the AreaChart wrapper component, enabling users to pass additional props such as `margin` and `onClick`.
@jaieds jaieds changed the base branch from master to dev March 24, 2025 07:08
@vrundakansara vrundakansara merged commit a6ef72e into dev Mar 24, 2025
8 checks passed
@vrundakansara vrundakansara deleted the fixes-and-improvements branch March 24, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants