Skip to content

Comments

SUR-453 - [Dashboard] Site Search Traffic#307

Merged
vrundakansara merged 5 commits intostagingfrom
component/improvements
Apr 14, 2025
Merged

SUR-453 - [Dashboard] Site Search Traffic#307
vrundakansara merged 5 commits intostagingfrom
component/improvements

Conversation

@jaieds
Copy link
Contributor

@jaieds jaieds commented Apr 14, 2025

Description

  • fix: Prevent display of negative graph when no negative values are present
  • Showing incorrect option suggestions in the EditorInput component.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

Copy link
Contributor

@ravindrakele ravindrakele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still getting the old values in storybook's EditorInput, will it not work in storybook?
Do I need to check by linking with Surerank?

@vrundakansara vrundakansara merged commit 297a8c3 into staging Apr 14, 2025
8 checks passed
@vrundakansara vrundakansara deleted the component/improvements branch April 14, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants