Skip to content

SUR-476 - [Smart Tag Dropdown] Please fix the Smart Tag value dropdown in Meta sidebar #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vrundakansara merged 2 commits into from
Apr 23, 2025
Merged

SUR-476 - [Smart Tag Dropdown] Please fix the Smart Tag value dropdown in Meta sidebar #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8735e
fix: Dropdown not visible when accordion state is open
jaieds Apr 22, 2025
e456bcc
Update the change log
jaieds Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
Version 1.6.3 - xth April, 2025
- Fix - Resolved an issue where the Accordion component's content was not properly visible when expanded due to overflow hidden.

Version 1.6.2 - 14th April, 2025
- Improvement - Enhanced the LineChart component by refining the line type and optimizing the spacing between tooltip contents for better clarity and visual appeal.
- Fix - Resolved an issue in the EditorInput component where incorrect options were displayed due to a mismanaged global cache variable.
Expand Down
19 changes: 16 additions & 3 deletions src/components/accordion/accordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,21 @@ export const AccordionContent = ( {
className,
}: AccordionContentProps ) => {
const contentVariants = {
open: { height: 'auto', opacity: 1 },
closed: { height: 0, opacity: 0 },
open: {
height: 'auto',
opacity: 1,
overflow: 'unset',
transition: {
overflow: {
delay: 1,
},
},
},
closed: {
height: 0,
opacity: 0,
overflow: 'hidden',
},
};

const contentPaddingClasses = {
Expand All @@ -239,7 +252,7 @@ export const AccordionContent = ( {
exit="closed"
transition={ { duration: 0.3, ease: 'easeInOut' } }
className={ cn(
'overflow-hidden text-text-secondary w-full text-sm transition-[height, opacity, transform] ease-in box-border',
'text-text-secondary w-full text-sm transition-[height, opacity, transform] ease-in box-border',
disabled && 'opacity-40',
className
) }
Expand Down
Loading