Skip to content

Comments

Added : collapsible prop to accordian#319

Merged
vrundakansara merged 7 commits intostagingfrom
update/accordian
May 5, 2025
Merged

Added : collapsible prop to accordian#319
vrundakansara merged 7 commits intostagingfrom
update/accordian

Conversation

@earth9890
Copy link
Member

Description

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@earth9890 earth9890 requested a review from jaieds May 5, 2025 09:17
Copy link
Contributor

@jaieds jaieds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a story for this.

Copy link
Contributor

@jaieds jaieds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a change log.

@earth9890 earth9890 changed the title SUR-521 - Added : collapsible prop to accordian SUR-541 - Added : collapsible prop to accordian May 5, 2025
@earth9890 earth9890 requested a review from jaieds May 5, 2025 10:39
@earth9890
Copy link
Member Author

Add a change log.

Added changelog. Do we have to run something similar to grunt readme ?

@jaieds
Copy link
Contributor

jaieds commented May 5, 2025

Add a change log.

Added changelog. Do we have to run something similar to grunt readme ?

No.

earth9890 and others added 3 commits May 5, 2025 16:54
Co-authored-by: Jaied Al Sabid <87969327+jaieds@users.noreply.github.com>
Co-authored-by: Jaied Al Sabid <87969327+jaieds@users.noreply.github.com>
@earth9890 earth9890 requested a review from jaieds May 5, 2025 11:26
@jaieds jaieds requested a review from vrundakansara May 5, 2025 11:44
@vrundakansara vrundakansara merged commit 0af894a into staging May 5, 2025
4 checks passed
@vrundakansara vrundakansara deleted the update/accordian branch May 5, 2025 12:18
@earth9890 earth9890 changed the title SUR-541 - Added : collapsible prop to accordian Added : collapsible prop to accordian May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants