Skip to content

Comments

SUR-659 - Add enhanced Select component with JSX options and search functionality#354

Merged
vrundakansara merged 12 commits intostagingfrom
select-jsx-fix
Sep 12, 2025
Merged

SUR-659 - Add enhanced Select component with JSX options and search functionality#354
vrundakansara merged 12 commits intostagingfrom
select-jsx-fix

Conversation

@earth9890
Copy link
Member

@earth9890 earth9890 commented Sep 11, 2025

  • Enhanced utility function to support complex JSX structures.

Description

Screenshots | Video with voice-over

Link to Figma (If applicable)

How has this been tested?

Checklist:

  • My code is tested
  • Screenshot added in PR
  • Figma design linked
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I have resolved all lint issues
  • My templates are responsive
  • I've added conditional class names use cn()
  • I've followed theme color usage
  • I have used clear and relevant file paths

jaieds and others added 6 commits May 26, 2025 22:51
- Introduced `SiteSelectExample` demonstrating complex JSX components in options.
- Added `searchValue` prop to `Select.Option` for reliable search.
- Updated `SelectOptions` to utilize `searchValue` for filtering.
- Enhanced utility function to support complex JSX structures.
…t component for enhanced search functionality.
@earth9890 earth9890 requested a review from jaieds September 11, 2025 09:16
@vrundakansara vrundakansara changed the base branch from master to staging September 11, 2025 11:27
@vrundakansara
Copy link
Contributor

@earth9890 - I have changed the base to staging.

@earth9890 earth9890 requested a review from jaieds September 11, 2025 17:33
@vrundakansara vrundakansara merged commit d64c5e0 into staging Sep 12, 2025
4 checks passed
@vrundakansara vrundakansara deleted the select-jsx-fix branch September 12, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants