Fix grammar error in Alert component story#368
Conversation
Changed "it is been used" to "it has been used" in the WithLongStringAndWithoutCloseButton story example text. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| <p className="m-0"> | ||
| <b className="mr-1">Designer’s Note:</b>Adjusting or changing | ||
| <b className="mr-1">Designer's Note:</b>Adjusting or changing | ||
| components here will update it on all other pages or templates |
There was a problem hiding this comment.
What: Correct the grammar in the text for clarity, as you've already done. However, it's a good practice to review the context of grammatical changes in the entire codebase to ensure it complies with proper standards before finalizing.
Why: While the current change improves clarity, consistent grammatical standards in all parts of the codebase contribute to better readability and professionalism in documentation and comments. Ensuring that all strings are grammatically correct avoids miscommunication and enhances user experience.
How: Continuously review string literals across the codebase, looking for any further instances of unclear phrasing or common grammatical errors to improve overall quality.
| <p className="m-0"> | ||
| <b className="mr-1">Designer’s Note:</b>Adjusting or changing | ||
| <b className="mr-1">Designer's Note:</b>Adjusting or changing | ||
| components here will update it on all other pages or templates |
There was a problem hiding this comment.
What: The clarification in this code does not have security issues but it is still important to ensure that the content rendered (if coming from user input) is sanitized properly to avoid XSS risks. Ensure that content is safe and properly escaped in the future.
Why: Proper sanitization of inputs is vital for preventing XSS attacks. Although this particular change is benign, it is always a good practice to review how such content is handled in the rendering process to ensure security best practices are being followed.
How: Make sure to employ libraries or methods that sanitize HTML such as DOMPurify for content that is likely user-generated to ensure no malicious scripts are executed.
Changed 'Designer's' to 'Designer's' to comply with react/no-unescaped-entities rule. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
1 participant
Summary
Fixed grammar error in Alert component Storybook story.
Changes
WithLongStringAndWithoutCloseButtonstoryContext
Found during comprehensive strings review. This is the only grammar error identified across the codebase.
Files Changed
src/components/alert/alert.stories.tsx(line 87)Testing
🤖 Generated with Claude Code