Conversation
…s-1770453055841 Add Claude Code GitHub Workflow
Publish a new workflow for duplicating mirror image at brainstormforce/bsf-admin-ui
Update release trigger in .github/workflows/publish.yml and .github/workflows/publish-public-build.yml from types: [created] to types: [published] so the publish jobs run only when a release is published (not when a draft or created event occurs). This avoids premature or duplicate publish runs.
Replace the release: published trigger with push: branches: [master] in both publish workflows so publishing runs on pushes to the master branch instead of on GitHub release events. Files updated: .github/workflows/publish-public-build.yml and .github/workflows/publish.yml. No other job changes.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,12 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
What: The package name has been changed from '@bsf/force-ui' to '@brainstormforce/force-ui'. Ensure that this change is reflected in other dependent modules and components.
Why: Changing the package name can affect existing installations and usages of the library. It is crucial to ensure that all references across the codebase and any documentation are updated to prevent breakages.
How: Verify all instances where '@bsf/force-ui' is being used in your projects and update them to '@brainstormforce/force-ui'. Additionally, check for any dependencies that may require updates.
| "registry": "https://npm.pkg.github.com", | ||
| "access": "restricted" | ||
| }, | ||
| "exports": { |
There was a problem hiding this comment.
What: A new publishConfig section has been added with a registry and access level specified. Ensure that this configuration is necessary and correct.
Why: The publishConfig specifies how the package should be published to the GitHub Package Registry. Incorrect configurations may lead to publishing issues or security concerns with package access levels.
How: Confirm that the specified registry URL is correct and corresponds to your GitHub Packages setup. If access should be public rather than restricted, adjust the configuration accordingly.
| @@ -41,7 +45,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
What: The repository URL has been updated from a different repository to the correct one for this package.
Why: This ensures that anyone accessing the package will find the correct source code and can contribute or raise issues against the right repository. Keeping repository links accurate is important for maintainability.
How: Double-check that the new URL 'git+https://github.com/brainstormforce/force-ui.git' is accessible and reflects the intended destination for users who might wish to contribute.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
5 participants
Description
Screenshots | Video with voice-over
Link to Figma (If applicable)
How has this been tested?
Checklist: