add api key support for bedrock #377
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d881a0a4d3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/proxy/schema/secrets.ts
Outdated
| auth_type: z | ||
| .enum(["iam_credentials", "api_key"]) | ||
| .default("iam_credentials"), | ||
| access_key: z.string().nullish(), | ||
| session_token: z.string().nullish(), |
There was a problem hiding this comment.
The schema now allows access_key to be null for all Bedrock secrets while auth_type defaults to iam_credentials. In that default path the runtime code still dereferences accessKeyId! when building credentials, so a secret created without access_key will pass validation but later send undefined to the AWS SDK and fail authentication at runtime. This only happens when auth_type is omitted or set to iam_credentials, so consider making access_key required for that case (or adding conditional validation) to avoid silent misconfiguration.
Useful? React with 👍 / 👎.
No description provided.