Update Router.php #160
Open
Update Router.php #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aliasing global functions
Collaborator
|
Why should this be implemented? Any special use or something? 🤔 |
Owner
|
It has to do with performance — https://www.bram.us/2020/04/18/php-performance-tip-use-fully-qualified-function-calls-when-working-with-namespaces/ |
Author
|
bramus is right, though I do believe its should be like this to become a fully qualified name? Its also convenient for developers that appreciate a quick overview of used functions. |
Collaborator
|
Mh. I actually never thought about this, but it makes perfectly sense. Thanks 👍 LGTM this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliasing global functions