fix: restore local eslint config for standalone checkouts#1
Open
lawyered0 wants to merge 1 commit intobrandonwise:mainfrom
Open
fix: restore local eslint config for standalone checkouts#1lawyered0 wants to merge 1 commit intobrandonwise:mainfrom
lawyered0 wants to merge 1 commit intobrandonwise:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
npm run lintfails in a clean clone of this repository becauseeslint.config.jsimports../_config/eslint.base.js, but that path is not present in this project.That means contributors (and CI setups that lint from this repo alone) cannot run lint successfully.
Root cause
eslint.config.jswas refactored to depend on a shared config path used in another local setup, but that dependency is not checked into this repository.What this PR changes
eslint.config.jssrc/**/*.js(Node/CommonJS globals + project rules)tests/**/*.js(test/module globals + test rules)node_modules/,coverage/,dist/)Why this is safe
eslint.config.jsReproduction (before)
npm installnpm run lintCannot find module '../_config/eslint.base.js'Verification (after)
npm run lintcompletes successfully (2 existing non-blocking warnings insrc/patterns.js)npm testpasses (128/128)npm run format:checkpasses