remove 'www.' subdomain prefix stripping behavior#618
Merged
Conversation
Not only is it slightly problematic (#611); uBlock Origin doesn't even have any similar behavior. No reason to keep it.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
Details
| Benchmark suite | Current: 1e60e03 | Previous: 86df054 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
1962518393 ns/iter (± 15600796) |
1936929560 ns/iter (± 18099906) |
1.01 |
rule-match-first-request/brave-list |
1099581 ns/iter (± 8025) |
1104116 ns/iter (± 8338) |
1.00 |
blocker_new/brave-list |
147230044 ns/iter (± 1648423) |
146862325 ns/iter (± 1052723) |
1.00 |
blocker_new/brave-list-deserialize |
26945605 ns/iter (± 433774) |
25549405 ns/iter (± 1920810) |
1.05 |
memory-usage/brave-list-initial |
10633093 ns/iter (± 3) |
10630445 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/max |
61950746 ns/iter (± 3) |
61948094 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/alloc-count |
1030644 ns/iter (± 3) |
1030640 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests |
2316792 ns/iter (± 3) |
2316792 ns/iter (± 3) |
1 |
memory-usage/brave-list-1000-requests/alloc-count |
70181 ns/iter (± 3) |
70181 ns/iter (± 3) |
1 |
url_cosmetic_resources/brave-list |
191767 ns/iter (± 1549) |
192120 ns/iter (± 886) |
1.00 |
cosmetic-class-id-match/brave-list |
3398362 ns/iter (± 932704) |
3424237 ns/iter (± 943882) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #611