Skip to content

Comments

Add node v10 to Travis matrix and clean up some tests#1634

Merged
brianc merged 3 commits intobrianc:masterfrom
sehrope:travis-ci-node-v10
May 4, 2018
Merged

Add node v10 to Travis matrix and clean up some tests#1634
brianc merged 3 commits intobrianc:masterfrom
sehrope:travis-ci-node-v10

Conversation

@sehrope
Copy link
Contributor

@sehrope sehrope commented May 3, 2018

Three commits in this PR:

  • First adds node v10 to the Travis build matrix (which fails)
  • Second changes the network partition test to use socket.destroy() rather than socket.end() (which fixes Travis)
  • Third updates deprecated new Buffer(...) to use Buffer.from(...).

I'm not sure what exactly changed in node v10 to require updating the test from socket.end() to socket.destroy() but suspect it's something internal to waiting for the socket to gracefully close. Haven't been able to find anything online regarding it either though that may be because v10 is so new.

I'm going to take a look if applying #1608 would correct this as well. Either way I think using destroy(...) is probably a good idea as that's what the test is simulated right? (i.e. network partition immediately killing the connection mid flight)

@brianc
Copy link
Owner

brianc commented May 3, 2018

Ah thanks! I'll be working on node-posgres most of the day tomorrow doing some overdue housekeeping & stuff so I'll merge this then!

@brianc
Copy link
Owner

brianc commented May 4, 2018

Yeah destroy looks good. Thanks for the PR!

@brianc brianc merged commit 860928e into brianc:master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants