Expose the original version of ArrayObject's getArrayCopy#5
Merged
brianlmoon merged 1 commit intomainfrom Dec 2, 2025
Merged
Conversation
…poses of sorting without needing to turn arrays in the resulting array output back into the objects they originally were
brianlmoon
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I want to sort the TypedArray (without using some of the built-in sorting methods from ArrayObject), I would have to call Class::getArrayCopy(), sort, and then convert all of my items in the sorted array back to their original objects. Exposing the original getArrayCopy() saves me from having to do that.
I'm open to alternative names for the method, though.