ring v0.13.2 build failing

[psivesely]

Error below is from my personal amd64 linux machine using the latest stable Rust. See also https://travis-ci.org/SpinResearch/RustySecrets/jobs/427165803.

   Compiling ring v0.13.2
     Running `rustc --crate-name build_script_build /home/noah/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.13.2/build.rs --crate-type bin --emit=dep-info,link -C debuginfo=2 --cfg 'feature="default"' --cfg 'feature="dev_urandom_fallback"' --cfg 'feature="use_heap"' -C metadata=6f90f0816d845991 -C extra-filename=-6f90f0816d845991 --out-dir /home/noah/src/SpinResearch/RustySecrets/target/debug/build/ring-6f90f0816d845991 -L dependency=/home/noah/src/SpinResearch/RustySecrets/target/debug/deps --extern cc=/home/noah/src/SpinResearch/RustySecrets/target/debug/deps/libcc-4d7e5b622d552dd0.rlib --cap-lints allow`
error: non-reference pattern used to match a reference (see issue #42640)
   --> /home/noah/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.13.2/build.rs:375:9
    |
375 |     let (_, _, perlasm_format) = ASM_TARGETS.iter().find(|entry| {
    |         ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a reference: `&(_, _, perlasm_format)`

error: non-reference pattern used to match a reference (see issue #42640)
   --> /home/noah/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.13.2/build.rs:674:9
    |
674 |     for (src, dst) in src_dst {
    |         ^^^^^^^^^^ help: consider using a reference: `&(src, dst)`

error: non-reference pattern used to match a reference (see issue #42640)
   --> /home/noah/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.13.2/build.rs:737:35
    |
737 |             RING_SRCS.iter().any(|(_, f)| cmp(f)) ||
    |                                   ^^^^^^ help: consider using a reference: `&(_, f)`

error: non-reference pattern used to match a reference (see issue #42640)
   --> /home/noah/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.13.2/build.rs:741:35
    |
741 |             RING_SRCS.iter().any(|(_, f)| cmp(f)) ||
    |                                   ^^^^^^ help: consider using a reference: `&(_, f)`

error: aborting due to 4 previous errors

error: Could not compile `ring`.

Caused by:
  process didn't exit successfully: `rustc --crate-name build_script_build /home/noah/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.13.2/build.rs --crate-type bin --emit=dep-info,link -C debuginfo=2 --cfg feature="default" --cfg feature="dev_urandom_fallback" --cfg feature="use_heap" -C metadata=6f90f0816d845991 -C extra-filename=-6f90f0816d845991 --out-dir /home/noah/src/SpinResearch/RustySecrets/target/debug/build/ring-6f90f0816d845991 -L dependency=/home/noah/src/SpinResearch/RustySecrets/target/debug/deps --extern cc=/home/noah/src/SpinResearch/RustySecrets/target/debug/deps/libcc-4d7e5b622d552dd0.rlib --cap-lints allow` (exit code: 101)

[briansmith]

The errors you are encountering look like the kind you would get if you were compiling with a release of rustc that is at least a couple of versions behind the current stable release.

Instead of that unusual way of building ring using rustc directly, please provide STR that use cargo. I can't reproduce it with cargo build using rustc 1.29.1.

[briansmith]

The errors you are encountering look like the kind you would get if you were compiling with a release of rustc that is at least a couple of versions behind the current stable release.

In fact, according to https://travis-ci.org/SpinResearch/RustySecrets/jobs/427165803:

rustc --version
info: syncing channel updates for '1.24.1-x86_64-unknown-linux-gnu'
info: latest update on 2018-03-01, rust version 1.24.1 (d3ae9a9e0 2018-02-27)

Try Rust 1.29.1.

[psivesely]

Thanks. There was a rust-toolchain file which I wasn’t aware of pinning it to that earlier version.