Skip to content

Remove README.md from .gitattributes#110

Merged
BenMorel merged 2 commits intobrick:masterfrom
williamdes:patch-1
Mar 5, 2026
Merged

Remove README.md from .gitattributes#110
BenMorel merged 2 commits intobrick:masterfrom
williamdes:patch-1

Conversation

@williamdes
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (dd4104a) to head (90672d9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #110   +/-   ##
=========================================
  Coverage     99.08%   99.08%           
  Complexity      660      660           
=========================================
  Files            18       18           
  Lines          1636     1636           
=========================================
  Hits           1621     1621           
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenMorel
Copy link
Member

BenMorel commented Mar 5, 2026

Hi, I think the CHANGELOG should stay. And I think it was a mistake to export-ignore the README file as well, do you want to change this?

@williamdes
Copy link
Contributor Author

Hi, I think the CHANGELOG should stay. And I think it was a mistake to export-ignore the README file as well, do you want to change this?

You are the maintainer, and it looks okay to me to have this decision. I applied your change

@williamdes
Copy link
Contributor Author

Hi, I think the CHANGELOG should stay. And I think it was a mistake to export-ignore the README file as well, do you want to change this?

And in fact I would have removed the CHANGELOG more than the README
users can read the changelog from the web interface.
rather than filling servers with markdown files

@BenMorel BenMorel changed the title Add the CHANGELOG.md to .gitattributes Remove README.md from .gitattributes Mar 5, 2026
@BenMorel BenMorel merged commit d9b8e5e into brick:master Mar 5, 2026
19 checks passed
@BenMorel
Copy link
Member

BenMorel commented Mar 5, 2026

Thank you, @williamdes!

@williamdes williamdes deleted the patch-1 branch March 5, 2026 15:13
@BenMorel
Copy link
Member

BenMorel commented Mar 5, 2026

And in fact I would have removed the CHANGELOG more than the README
users can read the changelog from the web interface.
rather than filling servers with markdown files

I think it's part of the documentation, together with the README. Let's keep it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants