feat(ozone/nexus): Assign VirtualKeyboard role to overlay windows OS-20973#129
Merged
caneraltinbasak merged 1 commit into28-x-y-bsfrom Apr 20, 2026
Merged
feat(ozone/nexus): Assign VirtualKeyboard role to overlay windows OS-20973#129caneraltinbasak merged 1 commit into28-x-y-bsfrom
caneraltinbasak merged 1 commit into28-x-y-bsfrom
Conversation
caneraltinbasak
changed the title
rsmith-brightsign
approved these changes
Apr 13, 2026
caneraltinbasak
force-pushed
the
cal/OS-20973
branch
from
84580de to
33b0197
Compare
Tooltip, popup, and menu windows were created without a Nexus surface role (eNone). After the SetZOrderLevel changes gave the main window a Graphics role, libbscompositor's role-based z-ordering placed the role-less overlay windows behind the graphics surface. Fix by assigning NEXUS_BrightSignSurfaceRole_eVirtualKeyboard to tooltip, popup, and menu windows at creation time. In the compositor's arrangement order (video > graphics > subtitles > ticker > virtual keyboard > cursor), this ensures overlays appear above the main graphics content.
caneraltinbasak
force-pushed
the
cal/OS-20973
branch
from
33b0197 to
216f39e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooltip, popup, and menu windows were created without a Nexus surface
role (eNone). After the SetZOrderLevel changes gave the main window a
Graphics role, libbscompositor's role-based z-ordering placed the
role-less overlay windows behind the graphics surface.
Fix by assigning NEXUS_BrightSignSurfaceRole_eVirtualKeyboard to
tooltip, popup, and menu windows at creation time. In the compositor's
arrangement order (video > graphics > subtitles > ticker > virtual
keyboard > cursor), this ensures overlays appear above the main
graphics content.