fix(ozone/nexus): Transfer keyboard focus to next window on destroy OS-21049#132
Merged
caneraltinbasak merged 1 commit into28-x-y-bsfrom Apr 20, 2026
Merged
fix(ozone/nexus): Transfer keyboard focus to next window on destroy OS-21049#132caneraltinbasak merged 1 commit into28-x-y-bsfrom
caneraltinbasak merged 1 commit into28-x-y-bsfrom
Conversation
…S-21049 When the topmost focused window is destroyed, keyboard_grabber_ was reset to kNullAcceleratedWidget with no fallback, causing all subsequent keyboard events to be silently dropped until a mouse click or touch reassigned focus. Fix RemoveWindow() to iterate the remaining windows in reverse order (topmost first) and transfer keyboard focus to the first activatable window. Also call Activate() on the new focus recipient so its delegate is notified via OnActivationChanged(true). Add NexusWindow::IsActivatable() accessor to support the check from the window manager.
t-bashir-bs
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the topmost focused window is destroyed, keyboard_grabber_ was reset to kNullAcceleratedWidget with no fallback, causing all subsequent keyboard events to be silently dropped until a mouse click or touch reassigned focus.
Fix RemoveWindow() to iterate the remaining windows in reverse order (topmost first) and transfer keyboard focus to the first activatable window. Also call Activate() on the new focus recipient so its delegate is notified via OnActivationChanged(true).
Add NexusWindow::IsActivatable() accessor to support the check from the window manager.