Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #19.
python/setup.py: detect X11 paths at build time on macOS via pkg-config, falling back to known Homebrew prefixes (/opt/homebrew,/usr/local)..github/workflows/wheels.yml: addmacos-latestto the build. UsesCIBW_BEFORE_ALL_MACOSto install required libs via brew. SetsMACOSX_DEPLOYMENT_TARGETto match the X11 libs on the runner. Added workflow_dispatch so the build can be triggered manually from the GitHub actions tab..github/workflows/release.yml: addmacos-latestto the build matrix so thatvbinary is also built on macOS for GitHub releases. Publish job uses wildcard so that both Linux and macOS wheels are uploaded to PyPI.Mac installation looks something like this:
we require an X11 server like XQuartz for running
this can also be installed from source, though this required the libraries for installation