fix relational scoping bug introduced in #6495 #6498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where ORDER BY scope was improperly handled because the logic favored the input table over the column aliases but the materialized output table has priority over the input table once the SELECT body scope is left. This would typically be handled by first looking into the output table but we can't do this because we do expression matching on the sem-tree expressions and we can't mix and match input expressions with the output expressions. The fix is to look in the columns first (producing input table expressions) and matching those expressions to the grouped output table columns with the expression matcher.
Collaborator
Author
|
This should fix the intermittent test failure in #6496 |
nwt
approved these changes
Jan 7, 2026
compiler/semantic/scope.go
Outdated
| // SELECT body (e.g., in ORDER BY), so we need to first check | ||
| // the select column names before the inputs. This is handled by | ||
| // other SQLs by looking in the output table, but we can't do that | ||
| // since we must can't mix output columns and input columns |
Member
There was a problem hiding this comment.
Suggested change
| // since we must can't mix output columns and input columns | |
| // since we can't mix output columns and input columns |
| inputs: | ||
| - name: query.spq | ||
| data: | | ||
| pragma pg=false |
Member
There was a problem hiding this comment.
Is this what you want? I was expecting pg=true based on the file name.
Collaborator
Author
There was a problem hiding this comment.
Oops, you're right. The bug was when PG scope was off and it was the output table causing the problem. I'll rename the file.
Collaborator
Author
There was a problem hiding this comment.
And remove pg=false
compiler/semantic/scope.go
Outdated
| // the binding of identifiers changes and query results can change. By | ||
| // resolving lateral aliases first, we avoid this problem. | ||
| // resolving lateral aliases first, we avoid this problem. This can | ||
| // be overridden with "pragma pg" to favor Postgres precedence. |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| // be overridden with "pragma pg" to favor Postgres precedence. | |
| // be overridden with "pragma pg" to favor PostgreSQL precedence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where ORDER BY scope was improperly handled because the logic favored the input table over the column aliases but the materialized output table has priority over the input table once the SELECT body scope is left. This would typically be handled by first looking into the output table but we can't do this because we do expression matching on the sem-tree expressions and we can't mix and match input expressions with the output expressions. The fix is to look in the columns first (producing input table expressions) and matching those expressions to the grouped output table columns with the expression matcher.