drop column alias resolution from HAVING clause as in PostgreSQL

[mccanne]

No description provided.

[nwt]

Out of curiosity, why is it safe to set scope.lateral to true on these paths (rather than restoring whatever value it had before it was set to false)?

[mccanne]

Out of curiosity, why is it safe to set scope.lateral to true on these paths (rather than restoring whatever value it had before it was set to false)?

I think they should all work this way in sqlSelect. We are adjusting knobs in the scope that was created by sqlSelect. It's the expr recursion that should save and restore settings.

[philrz]

I've confirmed that this addresses a problem with these 6 sqllogictest queries:

• random/groupby/slt_good_10/q8399
• random/groupby/slt_good_12/q8719
• random/groupby/slt_good_12/q10410
• random/groupby/slt_good_12/q10695
• random/groupby/slt_good_12/q10816
• random/groupby/slt_good_12/q10869

In a previous pass, I'd ensured the pragma pg from #6495 was present in the sqllogictest queries in which a column alias from the SELECT was referenced in the GROUP BY. However, these six queries didn't fit that criteria so were not being executed with pragma pg, but I noticed they were failing with these aggregate function ... called in non-aggregate context errors unless I added the pragma pg.

$ super -version
Version: 1ffd06a60

$ super -c "SELECT - + col2 * - AVG ( - col2 ) AS col0 FROM tab0 cor0 GROUP BY col2, col1, col2 HAVING ( - col2 + AVG ( + col0 ) ) IS NULL;"
aggregate function "avg" called in non-aggregate context at line 1, column 21:
SELECT - + col2 * - AVG ( - col2 ) AS col0 FROM tab0 cor0 GROUP BY col2, col1, col2 HAVING ( - col2 + AVG ( + col0 ) ) IS NULL;
                    ~~~~~~~~~~~~~~
aggregate function "avg" called in non-aggregate context at line 1, column 21:
SELECT - + col2 * - AVG ( - col2 ) AS col0 FROM tab0 cor0 GROUP BY col2, col1, col2 HAVING ( - col2 + AVG ( + col0 ) ) IS NULL;
                    ~~~~~~~~~~~~~~

$ super -c "SELECT DISTINCT - COUNT ( - col0 ) AS col2 FROM tab1 GROUP BY col0, col0 HAVING NOT NULL BETWEEN ( - + 94 + 83 + + - col0 - col0 * - 38 / ( 35 * - AVG ( col2 * col2 ) ) ) AND NULL;"
aggregate function "count" called in non-aggregate context at line 1, column 19:
SELECT DISTINCT - COUNT ( - col0 ) AS col2 FROM tab1 GROUP BY col0, col0 HAVING NOT NULL BETWEEN ( - + 94 + 83 + + - col0 - col0 * - 38 / ( 35 * - AVG ( col2 * col2 ) ) ) AND NULL;
                  ~~~~~~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 19:
SELECT DISTINCT - COUNT ( - col0 ) AS col2 FROM tab1 GROUP BY col0, col0 HAVING NOT NULL BETWEEN ( - + 94 + 83 + + - col0 - col0 * - 38 / ( 35 * - AVG ( col2 * col2 ) ) ) AND NULL;
                  ~~~~~~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 19:
SELECT DISTINCT - COUNT ( - col0 ) AS col2 FROM tab1 GROUP BY col0, col0 HAVING NOT NULL BETWEEN ( - + 94 + 83 + + - col0 - col0 * - 38 / ( 35 * - AVG ( col2 * col2 ) ) ) AND NULL;
                  ~~~~~~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 19:
SELECT DISTINCT - COUNT ( - col0 ) AS col2 FROM tab1 GROUP BY col0, col0 HAVING NOT NULL BETWEEN ( - + 94 + 83 + + - col0 - col0 * - 38 / ( 35 * - AVG ( col2 * col2 ) ) ) AND NULL;
                  ~~~~~~~~~~~~~~~~

$ super -c "SELECT DISTINCT - col1 * - - MAX ( DISTINCT + - col1 ) + + + 62 AS col0 FROM tab2 GROUP BY col1 HAVING NOT - AVG ( ALL - col0 ) IS NOT NULL;"
aggregate function "max" called in non-aggregate context at line 1, column 30:
SELECT DISTINCT - col1 * - - MAX ( DISTINCT + - col1 ) + + + 62 AS col0 FROM tab2 GROUP BY col1 HAVING NOT - AVG ( ALL - col0 ) IS NOT NULL;
                             ~~~~~~~~~~~~~~~~~~~~~~~~~
aggregate function "max" called in non-aggregate context at line 1, column 30:
SELECT DISTINCT - col1 * - - MAX ( DISTINCT + - col1 ) + + + 62 AS col0 FROM tab2 GROUP BY col1 HAVING NOT - AVG ( ALL - col0 ) IS NOT NULL;
                             ~~~~~~~~~~~~~~~~~~~~~~~~~

$ super -c "SELECT + COUNT ( DISTINCT + + col0 ) AS col1, col2 FROM tab2 AS cor0 GROUP BY col0, col2 HAVING NOT + COUNT ( - col1 ) + + + SUM ( DISTINCT - 33 ) + - COUNT ( * ) * - + 56 * ( col0 ) IS NOT NULL;"
aggregate function "count" called in non-aggregate context at line 1, column 10:
SELECT + COUNT ( DISTINCT + + col0 ) AS col1, col2 FROM tab2 AS cor0 GROUP BY col0, col2 HAVING NOT + COUNT ( - col1 ) + + + SUM ( DISTINCT - 33 ) + - COUNT ( * ) * - + 56 * ( col0 ) IS NOT NULL;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 10:
SELECT + COUNT ( DISTINCT + + col0 ) AS col1, col2 FROM tab2 AS cor0 GROUP BY col0, col2 HAVING NOT + COUNT ( - col1 ) + + + SUM ( DISTINCT - 33 ) + - COUNT ( * ) * - + 56 * ( col0 ) IS NOT NULL;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~

$ super -c "SELECT + COUNT ( * ) AS col1, - 0 * + - 69 * + ( + 53 ) AS col1 FROM tab0 WHERE NOT NULL IS NOT NULL GROUP BY col2 HAVING ( COUNT ( col1 ) ) IS NULL;"
aggregate function "count" called in non-aggregate context at line 1, column 10:
SELECT + COUNT ( * ) AS col1, - 0 * + - 69 * + ( + 53 ) AS col1 FROM tab0 WHERE NOT NULL IS NOT NULL GROUP BY col2 HAVING ( COUNT ( col1 ) ) IS NULL;
         ~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 10:
SELECT + COUNT ( * ) AS col1, - 0 * + - 69 * + ( + 53 ) AS col1 FROM tab0 WHERE NOT NULL IS NOT NULL GROUP BY col2 HAVING ( COUNT ( col1 ) ) IS NULL;
         ~~~~~~~~~~~

$ super -c "SELECT + col1, col1 + - COUNT ( * ) / - + 35 AS col2 FROM tab0 GROUP BY col1, col0 HAVING NOT - col0 - + + col0 BETWEEN + NULLIF ( + COUNT ( ALL - col1 ), - col0 * - + 61 / ( + + col0 ) * MAX ( DISTINCT + ( - NULLIF ( - col2, - col2 - - col2 ) ) ) + + col0 ) AND + col0 * - + col1;"
aggregate function "count" called in non-aggregate context at line 1, column 25:
SELECT + col1, col1 + - COUNT ( * ) / - + 35 AS col2 FROM tab0 GROUP BY col1, col0 HAVING NOT - col0 - + + col0 BETWEEN + NULLIF ( + COUNT ( ALL - col1 ), - col0 * - + 61 / ( + + col0 ) * MAX ( DISTINCT + ( - NULLIF ( - col2, - col2 - - col2 ) ) ) + + col0 ) AND + col0 * - + col1;
                        ~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 25:
SELECT + col1, col1 + - COUNT ( * ) / - + 35 AS col2 FROM tab0 GROUP BY col1, col0 HAVING NOT - col0 - + + col0 BETWEEN + NULLIF ( + COUNT ( ALL - col1 ), - col0 * - + 61 / ( + + col0 ) * MAX ( DISTINCT + ( - NULLIF ( - col2, - col2 - - col2 ) ) ) + + col0 ) AND + col0 * - + col1;
                        ~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 25:
SELECT + col1, col1 + - COUNT ( * ) / - + 35 AS col2 FROM tab0 GROUP BY col1, col0 HAVING NOT - col0 - + + col0 BETWEEN + NULLIF ( + COUNT ( ALL - col1 ), - col0 * - + 61 / ( + + col0 ) * MAX ( DISTINCT + ( - NULLIF ( - col2, - col2 - - col2 ) ) ) + + col0 ) AND + col0 * - + col1;
                        ~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 25:
SELECT + col1, col1 + - COUNT ( * ) / - + 35 AS col2 FROM tab0 GROUP BY col1, col0 HAVING NOT - col0 - + + col0 BETWEEN + NULLIF ( + COUNT ( ALL - col1 ), - col0 * - + 61 / ( + + col0 ) * MAX ( DISTINCT + ( - NULLIF ( - col2, - col2 - - col2 ) ) ) + + col0 ) AND + col0 * - + col1;
                        ~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 25:
SELECT + col1, col1 + - COUNT ( * ) / - + 35 AS col2 FROM tab0 GROUP BY col1, col0 HAVING NOT - col0 - + + col0 BETWEEN + NULLIF ( + COUNT ( ALL - col1 ), - col0 * - + 61 / ( + + col0 ) * MAX ( DISTINCT + ( - NULLIF ( - col2, - col2 - - col2 ) ) ) + + col0 ) AND + col0 * - + col1;
                        ~~~~~~~~~~~
aggregate function "count" called in non-aggregate context at line 1, column 25:
SELECT + col1, col1 + - COUNT ( * ) / - + 35 AS col2 FROM tab0 GROUP BY col1, col0 HAVING NOT - col0 - + + col0 BETWEEN + NULLIF ( + COUNT ( ALL - col1 ), - col0 * - + 61 / ( + + col0 ) * MAX ( DISTINCT + ( - NULLIF ( - col2, - col2 - - col2 ) ) ) + + col0 ) AND + col0 * - + col1;
                        ~~~~~~~~~~~

Now that the changes from this PR have merged to main, these all run ok and produce the same output as Postgres, still without the need for the pragma pg.

$ super -version
Version: ab7c02895

$ super -c "SELECT - + col2 * - AVG ( - col2 ) AS col0 FROM tab0 cor0 GROUP BY col2, col1, col2 HAVING ( - col2 + AVG ( + col0 ) ) IS NULL;"
[no output]

$ super -c "SELECT DISTINCT - COUNT ( - col0 ) AS col2 FROM tab1 GROUP BY col0, col0 HAVING NOT NULL BETWEEN ( - + 94 + 83 + + - col0 - col0 * - 38 / ( 35 * - AVG ( col2 * col2 ) ) ) AND NULL;"
[no output]

$ super -c "SELECT DISTINCT - col1 * - - MAX ( DISTINCT + - col1 ) + + + 62 AS col0 FROM tab2 GROUP BY col1 HAVING NOT - AVG ( ALL - col0 ) IS NOT NULL;"
[no output]

$ super -c "SELECT + COUNT ( DISTINCT + + col0 ) AS col1, col2 FROM tab2 AS cor0 GROUP BY col0, col2 HAVING NOT + COUNT ( - col1 ) + + + SUM ( DISTINCT - 33 ) + - COUNT ( * ) * - + 56 * ( col0 ) IS NOT NULL;"
[no output]

$ super -c "SELECT + COUNT ( * ) AS col1, - 0 * + - 69 * + ( + 53 ) AS col1 FROM tab0 WHERE NOT NULL IS NOT NULL GROUP BY col2 HAVING ( COUNT ( col1 ) ) IS NULL;"
[no output]

$ super -c "SELECT + col1, col1 + - COUNT ( * ) / - + 35 AS col2 FROM tab0 GROUP BY col1, col0 HAVING NOT - col0 - + + col0 BETWEEN + NULLIF ( + COUNT ( ALL - col1 ), - col0 * - + 61 / ( + + col0 ) * MAX ( DISTINCT + ( - NULLIF ( - col2, - col2 - - col2 ) ) ) + + col0 ) AND + col0 * - + col1;"
{"+col1":81,col2:81}
{"+col1":0,col2:0}
{"+col1":0,col2:0}

Thanks @mccanne!