Skip to content

Conversation

@vadym-panchuk
Copy link
Contributor

The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

Fix in the PR

Co-authored-by: Caleb Maclennan <caleb@alerque.com>
@tkachuk
Copy link

tkachuk commented Mar 29, 2022

Hi @alerque, could you check this PR again ?
Thanks

@alerque
Copy link
Contributor

alerque commented Mar 29, 2022

This change itself looks good. The next step is a matter of how the repo is maintained. Just fixing this in the rockspec doesn't get it published to LuaRocks. While it is possible to force push an updated rockspec, that will break checksums for distro packaging downstream. I think the correct way to handle this is bump the rockrel in a new file to -3. That probably means this file needs to be copied to the new rockspec file location and the version bumped in combination with making this change to the file. How that happens logistically is up to the maintainer.

@r-bk
Copy link

r-bk commented Apr 17, 2022

@brimworks @alerque Hi! What is the status of this PR?
Currently it is impossible to install lua-zlib with luarocks.
Is there a plan to merge this PR and publish the 1.2-2 version?

@r-bk
Copy link

r-bk commented Apr 17, 2022

This change itself looks good. The next step is a matter of how the repo is maintained. Just fixing this in the rockspec doesn't get it published to LuaRocks. While it is possible to force push an updated rockspec, that will break checksums for distro packaging downstream. I think the correct way to handle this is bump the rockrel in a new file to -3. That probably means this file needs to be copied to the new rockspec file location and the version bumped in combination with making this change to the file. How that happens logistically is up to the maintainer.

@alerque The latest version published on https://luarocks.org/modules/brimworks/lua-zlib is 1.2-1.
This PR creates 1.2-2. Isn't this enough? Why -3 is needed?

@brimworks brimworks merged commit c4b948b into brimworks:master Apr 18, 2022
@brimworks
Copy link
Owner

Happy Easter! Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants