Skip to content

Conversation

@alerque
Copy link
Contributor

@alerque alerque commented Jun 10, 2022

My 2 year old PR #52 worked fine when submitted, but the cheese has moved upstream a bit since then.

alerque added 3 commits June 10, 2022 16:32
This turned into a mismanaged bloated project, will find another C linter..
@alerque alerque marked this pull request as ready for review June 10, 2022 13:39
@alerque
Copy link
Contributor Author

alerque commented Jun 10, 2022

There, with updated testing tools CI is reporting green.

The ones merged just a bit ago were 2 year old versions of everything, some of which had been deprecated and wasn't functional any more. This should be read, at least for the Lua stuff. I don't know what the best C linter to use is these days so I left it out for now (I do know that superlinter is a pain so recommending avoiding that).

Copy link
Owner

@brimworks brimworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks for the quick fix here.

@brimworks brimworks merged commit 0cedeec into brimworks:master Jun 10, 2022
@alerque alerque deleted the ci-tests branch June 10, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants