CI: use up-to-date GitHub Actions to install Lua and LuaRocks #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
approved these changes
Jan 31, 2025
Contributor
|
I can confirm this looks right and is definitely needed at this time. |
Contributor
Author
|
politely ping @brimworks |
Owner
|
Thanks for the contribution, sooI missed this one earlier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, it's well known by the Lua community that the current GitHub Action (https://github.com/leafo/gh-actions-lua) configured on this project is unable to install LuaJIT (see leafo/gh-actions-lua#49), because tarballs were removed from LuaJIT website, causing the action to fail.
Nowadays, it's a common practice for Lua projects hosted on GitHub to employ the (forked and) up-to-date actions https://github.com/luarocks/gh-actions-lua to install Lua and https://github.com/luarocks/gh-actions-luarocks to install LuaRocks.
I think that @alerque could be interested on this, because he contributed on this repository recently, and he is often involved with such actions.
Note
I've found a few issues on this library, and I have prepared fixes for them. However, the current CI is failing on such LuaJIT installation issues, which could be resolved first by merging this PR.