Skip to content

Add project to Fleet Protocol system#10

Merged
Nothrax merged 1 commit intomainfrom
add_system_name
Jan 15, 2026
Merged

Add project to Fleet Protocol system#10
Nothrax merged 1 commit intomainfrom
add_system_name

Conversation

@Nothrax
Copy link
Member

@Nothrax Nothrax commented Jan 15, 2026

Summary by CodeRabbit

  • Chores
    • Updated build system configuration to include required package dependencies and initialization routines to support protocol functionality without modifying existing storage settings.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Walkthrough

Added CMake package discovery and initialization for CMLIB CMCONF component to CMLibStorage.cmake. Two lines introduced: FIND_PACKAGE call to locate CMLIB with CMCONF component requirement, and CMCONF_INIT_SYSTEM call for FLEET_PROTOCOL initialization.

Changes

Cohort / File(s) Summary
CMake Build Configuration
CMLibStorage.cmake
Added FIND_PACKAGE(CMLIB REQUIRED COMPONENTS CMCONF) and CMCONF_INIT_SYSTEM(FLEET_PROTOCOL) initialization calls (+4 lines)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: adding CMake configuration to integrate the project into the Fleet Protocol system via CMCONF_INIT_SYSTEM(FLEET_PROTOCOL).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add_system_name


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a10ac51 and 7af777d.

📒 Files selected for processing (1)
  • CMLibStorage.cmake
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: mikusaq
Repo: bringauto/packager PR: 24
File: example/package/fleet-protocol-internal-client/internal_client_debug.json:23-23
Timestamp: 2024-10-09T05:03:50.249Z
Learning: The repository URL for 'fleet-protocol-internal-client' is 'https://github.com/bringauto/internal-client-cpp.git', not 'https://github.com/bringauto/fleet-protocol-internal-client.git'.
Learnt from: mikusaq
Repo: bringauto/mission-module PR: 23
File: CMLibStorage.cmake:1-3
Timestamp: 2025-04-03T11:53:12.434Z
Learning: In CMLibStorage.cmake, the variable declaration `SET(STORAGE_LIST DEP)` is intentional and should not be changed to `SET(STORAGE_LIST_DEP)` despite appearing to be inconsistent with the later usage.
📚 Learning: 2025-04-03T11:53:12.434Z
Learnt from: mikusaq
Repo: bringauto/mission-module PR: 23
File: CMLibStorage.cmake:1-3
Timestamp: 2025-04-03T11:53:12.434Z
Learning: In CMLibStorage.cmake, the variable declaration `SET(STORAGE_LIST DEP)` is intentional and should not be changed to `SET(STORAGE_LIST_DEP)` despite appearing to be inconsistent with the later usage.

Applied to files:

  • CMLibStorage.cmake
📚 Learning: 2024-10-03T17:41:56.410Z
Learnt from: Mayt34
Repo: bringauto/transparent-module PR: 1
File: CMakeLists.txt:15-20
Timestamp: 2024-10-03T17:41:56.410Z
Learning: In the `transparent_module` project, all modules should be built by default; `FLEET_PROTOCOL_BUILD_MODULE_GATEWAY` and `FLEET_PROTOCOL_BUILD_EXTERNAL_SERVER` should be set to ON by default.

Applied to files:

  • CMLibStorage.cmake
🔇 Additional comments (1)
CMLibStorage.cmake (1)

1-3: LGTM! The Fleet Protocol system initialization is correctly structured.

The package discovery and initialization follow proper CMake practices:

  1. FIND_PACKAGE with REQUIRED ensures the build fails if CMLIB/CMCONF is unavailable.
  2. CMCONF_INIT_SYSTEM(FLEET_PROTOCOL) is called after the package is found, maintaining correct dependency order.

This change achieves the PR objective of adding the project to the Fleet Protocol system.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nothrax Nothrax requested a review from koudis January 15, 2026 09:39
@Nothrax Nothrax merged commit f081278 into main Jan 15, 2026
1 check passed
@Nothrax Nothrax deleted the add_system_name branch January 15, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants