Add support for unidirectional and bidirectional streams with configurable stream-mode#50
Open
danprudky wants to merge 63 commits intoBAF-1256/use_quic_external_clientfrom
Open
Add support for unidirectional and bidirectional streams with configurable stream-mode#50danprudky wants to merge 63 commits intoBAF-1256/use_quic_external_clientfrom
stream-mode#50danprudky wants to merge 63 commits intoBAF-1256/use_quic_external_clientfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…pport to ExternalClient
…ogging, and implement connection management.
…lement connection state management, improve logging, and refine cleanup processes.
…improved state debugging
…ate with external_client::connection::ConnectionState
…ings::Constants::ALPN` for improved configurability.
…s after `receiveMessage` calls.
…sistent include order and readability.
…ed memory handling, update QUIC stream send logic, refine logging with stream IDs, and switch `initRegistration` to use `std::string`.
…er::logError` for error handling and ensure graceful returns in failure scenarios.
…::unique_ptr` with `std::string` for memory management.
…proper setup before logging.
…oped_lock` and simplify enum string conversion using `using enum`.
…initRegistration` with a constant for simplification and improved consistency.
…ique_ptr` in outbound queue, update `sendViaQuicStream` to use references for improved memory management and clarity.
…pand protocol support, and provide examples for both.
…dBuffer` to clarify purpose, usage, and construction.
… `settings::Constants` for improved maintainability.
…uicCommunication`.
…ectional streams with configurable `stream-mode`, improve error handling for missing or invalid settings, and update `QuicSettingsParser` to include `PeerUnidiStreamCount`.
…consistency across settings.
…ing, add NOLINT for reinterpret_cast, and enhance `PeerUnidiStreamCount` parsing logic.
…th default value support, improve error handling, and update `parseStreamMode` to default to bidirectional.
…invalid JSON keys, update documentation, and add `parseStreamMode` method with default behavior to handle stream modes.
…ompany_` members, update `createExternalClientConnect` to use settings from `context_`.
jiriskuta
force-pushed
the
BAF-1256/use_unidir_streams
branch
from
bd1d361 to
271b0e3
Compare
jiriskuta
force-pushed
the
BAF-1256/use_quic_external_client
branch
from
be11942 to
bf7ee48
Compare
|
jiriskuta
force-pushed
the
BAF-1256/use_quic_external_client
branch
from
bf7ee48 to
1bee77f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error handling for missing or invalid settings, and update
QuicSettingsParserto includePeerUnidiStreamCount.