Migration SignatureDataConversion to .NET Core #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2016 00:06
Project migration to Visual Studio 2015 / .NET Core
Project migration to Visual Studio 2015 and latest version of .NET Core and NUnit.
Author
|
Hi @brinley, I have prepared new Pull Request with correct version like you ask, and also updated references to latest version of .NET Core and NUnit. |
Author
|
And sorry for this last commit - I forgot few important files ;) Please merge all those commits into one :) |
Owner
|
Sorry I forgot to respond but you were right about this possibly a breaking check so we should update the major version number instead. I also noticed you updated the tests, have you executed them and they pass? |
Version update v2
Author
|
Ok, version is updated now to v2. Yes, all tests pass:
|
Owner
|
Thanks @lukaszdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration SignatureDataConversion_dotNet project to .NET Core / Visual Studio 2015.
This closes #113