File type not recognize since node 6.3.0

[Vinorcola]

Hello there,

I've encounter a compatibility break by switching from Node 6.2.2 to Node 6.3.0 (or higher, also try 6.3.1, 6.4.0, 6.5.0). I'm doing a ls command and my program is not detecting the file type (at least for directories). Here is my code:

let ftpConnection = new SftpClient(config.dataSourceOptions.sftpOptions)

return ftpConnection.ls(config.dataSourceOptions.sftpOptions.directory)
    .then(function(result)
    {
        console.log(result)
    })

Result with Node 6.2.2:

{
    path: "path/to/directory",
    type: "directory",
    attrs: {
        // ...
    },
    entries: [
        // ...
    ]
}

Result with Node >= 6.3.0

{
    path: "path/to/directory",
    type: "other",
    attrs: {
        // ...
    }
}

The directory type is not detected anymore. This is embarassing because I can't iterate through the "entry" option.

Now, I don't know if this is a (non-wanted) regression from Node or if it comes from this lib using deprecated code...

Thanks for your help.

[Vinorcola]

Looks like the code responsible for the stat is located here:

https://github.com/mscdex/ssh2-streams/blob/master/lib/sftp.js#L1579-L1605

I'm not competent enough to go any further though!

[brokenbot]

Hmm, that's a weird one, I imagining it's because of some outdated dependency I'm using. I'll take a look at this either today or tomorrow and see if I can't get it resolved. I need to do some dependency updates anyways.

Thank you for finding the stream code responsible for this it will make a debugging it a bit easier.

[brokenbot]

Took a bit track this down, but it looks like an issue with the way constants are laid out in in node < 6.3.0 and node >= 6.3.0 when using the code:

constants = process.binding('constants')

Which is what ssh2.streams does.

In node < 6.3.0:
constants { .... S_IFMT: 61440, S_IFREG: 32768, S_IFDIR: 16384, S_IFCHR: 8192, S_IFBLK: 24576, S_IFIFO: 4096, S_IFLNK: 40960, ... }

in node >= 6.3.0
constants { ... fs: { O_RDONLY: 0, O_WRONLY: 1, O_RDWR: 2, S_IFMT: 61440, S_IFREG: 32768, S_IFDIR: 16384, S_IFCHR: 8192, S_IFBLK: 24576, S_IFIFO: 4096, S_IFLNK: 40960, S_IFSOCK: 49152, ... }

I'll post a bug with the ssh2 project to see if they can't resolve this since my call is to their code, though really this might be a node bug.

[Vinorcola]

Ok, thanks for the quick answer ;)

Looks like process.binding is not meant to be used outside of Node kernel:
http://stackoverflow.com/questions/24042861/nodejs-what-does-process-binding-mean

Maybe that's why. They change the constant organization in 6.3.0 ...

[brokenbot]

Looks like there is a pull requests in ssh2-streams to resolve this issue.

I've verified their fix will resolve this issue. Once they update ssh2-streams I'll update the dependencies and close this bug.

Thank you for reporting it.

[brokenbot]

This should be resolved now, use version 1.4.0, it has updated dependencies for ssh2 and added a dependency for ssh2-streams 0.1.8 which resolves the underlying issue.

[Vinorcola]

Thank you for the fix.