Merged
Conversation
There was a problem hiding this comment.
Taking a look at the flag parsing, it feels a bit finnicky and manual to me, surely we can't use another flag-parsing library for this?
Also; I suggest emitting a warning in stderr instead of stdout regarding the current incompatibility of the color flag with iproute2mac, to make sure people aren't confused when there's no color, and that scripts relying on the stdout of the command dont get the garbage warning also piped to them.
brona
reviewed
Jan 14, 2023
Owner
brona
left a comment
brona
left a comment
There was a problem hiding this comment.
Thanks a lot for your PR! I added few comments to be resolved.
lexhuismans
requested review from
ShadowJonathan and
brona
and removed request for
ShadowJonathan and
brona
lexhuismans
requested review from
ShadowJonathan and
brona
and removed request for
ShadowJonathan and
brona
|
@brona any updates on this? |
brona
requested changes
Dec 3, 2023
lexhuismans
force-pushed
the
feature/ignore-color-option
branch
from
7cc487c to
574db79
Compare
brona
approved these changes
Dec 6, 2023
Owner
brona
left a comment
brona
left a comment
There was a problem hiding this comment.
Thanks! and sorry for the delays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ignores the color option when provided as suggested in Issue #21.
It ignores all the options starting with
-c[olor=always|never|auto]or--c[olor=always|never|auto]. Independent on where the option is provided.Also added orderless option for
-4and-6and--versionfor version, but this can be reverted.