Conversation
luoling8192
commented
Nov 16, 2024

|
Thank you for the PR, I will review it next week. |
|
Any news about implementing/merging this feature? As of 1.5.4 it is not implemented. |
|
Unfortunately, I didn't get back to this. As this is adding considerable amount of code and a class... Anyway two things that are possibly missing here:
Regarding the class added to iproute2mac.py file, I wonder if you could turn that into functions / or refactor that out into a separate file. |
I have a new fork for that, with |
|
Hey @brona |
- Initial implementation following ideas in #63, however changing the implementation to more closely match original behavior, adding original author to AUTHORS. - Default mode is `never` as that is what is Debian at the moment - Matching color scheme detection depending on `$COLORFGBG` - `NO_COLOR` is respected even with `--color=auto` mode - Supportable terminals are detected via `tput colors` and matching strings against `$TERM`
|
Thanks for the interest @alifiroozi80. I finally got some time to look into this one more closely. However the author took some liberties with the implementation which I don't necessarily agree with. Specifically:
That being said, big thanks @luoling8192 for starting this one! I took your ideas, merged them with mine and implemented that in 0b4bf6b, currently in HEAD, to recognize your contributions I added you to the AUTHORs file. Any chance someone could test the version from HEAD to see if there are any issues to be addressed before release? Closing this PR as we can follow up on the linked issues. |
