Fix k8s qa test#447
Merged
duncangrant merged 1 commit intobrooklyncentral:masterfrom May 21, 2018
Merged
Conversation
Testing recovery from killing k8s-master fails sometimes, if it chooses the first master (the only one with prometheus pod), as last test assertion is that prometheus is reachable.
Contributor
|
So the reason I didn't do this previously was because it felt like the code was wrong rather than the test. Should we add an issue to track this somewhere? |
duncangrant
approved these changes
May 21, 2018
Member
Author
|
Thanks @duncangrant - I've created #448 to capture/track a bigger improvement: to ensure that there is not a single-point-of-failure for prometheus. Are you happy to merge this PR as-is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing recovery from killing k8s-master fails sometimes, if it chooses
the first master (the only one with prometheus pod), as last test
assertion is that prometheus is reachable.