daemon: add Chrome Canary profile discovery#263
Open
femto wants to merge 1 commit intobrowser-use:mainfrom
Open
daemon: add Chrome Canary profile discovery#263femto wants to merge 1 commit intobrowser-use:mainfrom
femto wants to merge 1 commit intobrowser-use:mainfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/browser_harness/daemon.py">
<violation number="1" location="src/browser_harness/daemon.py:36">
P2: Putting Canary ahead of stable Chrome lets a stale `DevToolsActivePort` in Canary abort daemon startup before later, working Chrome profiles are tried.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Member
|
The cubic comment should be addressed before this is merged |
Add Chrome Canary paths to PROFILES list so the daemon can discover DevToolsActivePort from Canary installations: - macOS: ~/Library/Application Support/Google/Chrome Canary - Windows: ~/AppData/Local/Google/Chrome SxS/User Data Stable profiles are listed before Canary to avoid stale Canary port files blocking discovery (get_ws_url raises after 30s timeout). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
femto
force-pushed
the
add-chrome-canary-support
branch
from
88a7840 to
4bb1c59
Compare
Author
|
hello,resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROFILESlist for automatic DevToolsActivePort discovery~/Library/Application Support/Google/Chrome Canary~/AppData/Local/Google/Chrome SxS/User DataTest plan
🤖 Generated with Claude Code
Summary by cubic
Add Chrome Canary profile discovery so the daemon can auto-connect via DevToolsActivePort. Added macOS path ~/Library/Application Support/Google/Chrome Canary and Windows path ~/AppData/Local/Google/Chrome SxS/User Data, and keep stable Chrome ahead of Canary to avoid stale port files.
Written for commit 4bb1c59. Summary will update on new commits.