add warning when models are used with hybrid mode that will not perf…#1633
Merged
add warning when models are used with hybrid mode that will not perf…#1633
Conversation
🦋 Changeset detectedLatest commit: eb0dd6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Greptile OverviewGreptile SummaryThis PR adds a runtime warning when hybrid mode is used with models that may not perform optimally. The change logs a warning message with a link to the documentation when the model ID doesn't include "gemini-3-flash" or "claude". Key Changes:
Critical Issue Found:
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant V3AgentHandler
participant LLMClient
participant Logger
participant Agent
User->>V3AgentHandler: agent({ mode: "hybrid", model: "..." })
V3AgentHandler->>V3AgentHandler: prepareAgent()
V3AgentHandler->>LLMClient: getLanguageModel()
LLMClient-->>V3AgentHandler: baseModel (with modelId)
alt model is NOT recommended for hybrid
V3AgentHandler->>V3AgentHandler: Check modelId includes "gemini-3-flash" OR "claude"
V3AgentHandler->>Logger: log warning with docs link
Logger-->>User: Warning: model may not perform well
end
V3AgentHandler->>V3AgentHandler: Wrap model with middleware
V3AgentHandler-->>Agent: Return prepared agent config
Agent-->>User: Agent ready for execution
|
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 3/5
- Hardcoded model-name allowlist logic in
packages/core/lib/v3/handlers/v3AgentHandler.tsviolates the stated rule and could cause incorrect behavior as models change. - Severity is medium-high (7/10) with high confidence, so there is some regression/policy risk despite the change being localized.
- Pay close attention to
packages/core/lib/v3/handlers/v3AgentHandler.ts- hardcoded model-name checks for hybrid mode.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/core/lib/v3/handlers/v3AgentHandler.ts">
<violation number="1" location="packages/core/lib/v3/handlers/v3AgentHandler.ts:116">
P1: Rule violated: **Ensure we never check against hardcoded lists of allowed LLM model names**
Hardcoding model-name checks for hybrid mode violates the rule against allowlists of LLM model names. The new condition only treats "gemini-3-flash" and "claude" as acceptable, which will go stale as models change. Replace this with provider capability metadata or avoid model-name checks entirely.</violation>
</file>
Architecture diagram
sequenceDiagram
participant Client
participant Handler as V3AgentHandler
participant Model as BaseModel
participant Log as Logger
Client->>Handler: initializeAgent()
Handler->>Model: Inspect modelId
Model-->>Handler: modelId (e.g. "gpt-4o")
Note over Handler: Logic: Check if mode is "hybrid"
alt mode is "hybrid"
alt NEW: modelId DOES NOT include "gemini-3-flash" OR "claude"
Handler->>Log: NEW: logWarning()
Note right of Log: Includes link to docs for recommended models
else Model is recommended
Note over Handler,Log: Proceed without warning
end
end
Handler-->>Client: Return agent configuration (options, maxSteps, etc.)
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
pirate
approved these changes
Jan 29, 2026
This was referenced Jan 29, 2026
This was referenced Feb 5, 2026
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
hybrid mode requires specific models to perform optimally
what changed
if the models we recommend are not used, we throw an error log and link out to the agent docs
test plan
tested locally
Summary by cubic
Add a runtime warning when hybrid mode is used with models that may not perform well, linking to the docs with recommended models. This helps catch misconfiguration early and improves agent reliability.
Written for commit eb0dd6a. Summary will update on new commits. Review in cubic