[fix]: rm legacy handlePossibleNavigation()#1761
Merged
seanmcguire12 merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 1d2c3d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Greptile SummaryRemoves the legacy
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 1d2c3d6 |
victlue
approved these changes
Feb 26, 2026
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Handler as Action Handler
participant Frame as Browser Frame
participant Logger as v3Logger
Note over Handler, Frame: performUnderstudyMethod()
Handler->>Frame: Execute Browser Action (e.g. click)
alt Action triggers Page/Frame Closure
Frame-->>Handler: Success (Frame detached)
Note over Handler: CHANGED: No longer calls Frame.url() <br/> avoiding 'Frame detached' error logs
else Happy Path
Frame-->>Handler: Success (Frame exists)
end
opt Execution Error
Handler->>Logger: Log error & stack trace
end
Handler-->>Handler: Return result/error status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
clickElement()triggered page closure. this means that the frame.evaluate() to get the URL would attempt.evaluate()on a frame that no longer existedwhat changed
handlePossibleNavigation()test plan
Summary by cubic
Removed the legacy handlePossibleNavigation() that tried to detect navigation by URL and produced misleading logs. This also prevents errors when clicks close the page and evaluate runs on a non-existent frame, reducing log noise.
Written for commit 1d2c3d6. Summary will update on new commits. Review in cubic