[Fix] io.js 3.0 - Node.js 5.3 typed array support#25
Merged
ljharb merged 1 commit intobrowserify:masterfrom Nov 26, 2024
Merged
[Fix] io.js 3.0 - Node.js 5.3 typed array support#25ljharb merged 1 commit intobrowserify:masterfrom
ljharb merged 1 commit intobrowserify:masterfrom
Conversation
ChALkeR
force-pushed
the
chalker/fixes
branch
from
efaf142 to
1e3ee30
Compare
Member
|
LGTM after some added tests |
Contributor
Author
|
Added tests for (1-2) and (3) |
ChALkeR
force-pushed
the
chalker/fixes
branch
from
1e3ee30 to
2f2c1df
Compare
Contributor
Author
|
Wait, I apparently pushed... not here. Fixed |
ChALkeR
force-pushed
the
chalker/fixes
branch
from
2f2c1df to
e05b92d
Compare
ljharb
approved these changes
Nov 26, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Confirm the tests fail without the fix, in node 3 - 5.
ljharb
force-pushed
the
chalker/fixes
branch
from
e05b92d to
b7ddd2a
Compare
ljharb
changed the title
Member
|
Published in v1.0.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer(ab, offset, length)wasn't. So add a recheck for that case.instanceofcheck there due tosafe-bufferWhich was a regression in [Fix] return valid values on multi-byte-wide TypedArray input #23
Buffer(new Uint8Array(0).buffer)fails on empty buffers, add a hack for thatRefs: browserify/hash-base#19