[New] include filename in error message#161
[New] include filename in error message#161tcchau wants to merge 9 commits intobrowserify:masterfrom
Conversation
…into jmm-identify-parent Fix some styling/eslint errors; update planned test cases for tests to pass
Fix conflicts and ensure tests pass
Resolve conflicts resulting from upstream code that does not consider the parent file which may have triggered an error report.
since the error could be specific to a file now.
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Would you mind rebasing this so there's no merge commits? If you use git rebase --committer-date-is-author-date it will preserve the original commit dates :-)
|
|
||
| var extensions = opts.extensions || ['.js']; | ||
| var basedir = opts.basedir || path.dirname(caller()); | ||
| var y = opts.basedir || path.dirname(caller()); |
There was a problem hiding this comment.
Can this use a better name than "y"? I'd previously renamed this to "basedir" for clarity.
There was a problem hiding this comment.
Hi @ljharb I just basically left @jmm's code intact, but I can certainly change y to basedir instead.
However, note that y is really just a temporary variable and not intended to have any significant meaning, I'm guessing from @jmm's code, because at the end of the day, what you want is, parent and y just splits up the derivation of parent into two parts for clarity.
Anyway, let me know whether you still want y to be basedir and I will make the change.
There was a problem hiding this comment.
At the time they made their PR, the variable was called "y" :-) please do change it.
|
|
||
| var extensions = opts.extensions || ['.js']; | ||
| var basedir = opts.basedir || path.dirname(caller()); | ||
| var y = opts.basedir || path.dirname(caller()); |
|
Closing this PR because we want to have a clean history. |
|
@tcchau i'd have vastly preferred that you rebase instead of deleting the branch and closing the PR; is there any way to reopen this? I'm happy to do the rebase for you if needed. |
|
@ljharb Sorry, I couldn't see how to rebase without force pushing a new master, which prevents re-opening this PR. |
|
@tcchau yes, force pushing a new master would have done it (since the PR came from your master branch). |
|
@ljharb I haven't collaborated on Github in a long time, and forgot that best practice is to code your patch in a branch. I also honestly didn't expect to have to publish what I did since we were waiting for jmm to finish the PR. |
3 participants
Incorporates changes submitted by @jmm to fix Issue #60, resolves test errors and merges upstream changes. Was originally PR #64.
Fixes #60. Closes #64.