[Fix] properly handle paths with a trailing slash#53
Closed
fresheneesz wants to merge 2 commits intobrowserify:masterfrom
Closed
[Fix] properly handle paths with a trailing slash#53fresheneesz wants to merge 2 commits intobrowserify:masterfrom
fresheneesz wants to merge 2 commits intobrowserify:masterfrom
Conversation
ljharb
changed the title
ljharb
requested changes
Dec 13, 2016
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Would you mind rebasing as well when making these changes, and checking the "allow maintainers to edit" checkbox?
| @@ -0,0 +1,2 @@ | |||
| node_modules | |||
| npm-debug.log No newline at end of file | |||
Member
There was a problem hiding this comment.
please revert the gitignore changes; it's unrelated to this PR.
| @@ -0,0 +1 @@ | |||
| require('./test/') No newline at end of file | |||
Member
There was a problem hiding this comment.
please add a trailing newline on this file
| @@ -0,0 +1 @@ | |||
| console.log('file') No newline at end of file | |||
Member
There was a problem hiding this comment.
please add a trailing newline on this file
| @@ -0,0 +1 @@ | |||
| console.log('folder') No newline at end of file | |||
Member
There was a problem hiding this comment.
please add a trailing newline on this file
| var path = require('path') | ||
|
|
||
| test('issue 51', function (t) { | ||
| t.ok(resolve.sync('./issue51/test/') === path.resolve(__dirname, 'issue51/test/index.js')); |
Member
There was a problem hiding this comment.
should we also ensure that ./issue51/test/ is not equal to ./issue51/test when there's a test.js file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#51