Bug fix: Don't use acorn just because file ends with comment#17
Merged
goto-bus-stop merged 1 commit intobrowserify:masterfrom Feb 9, 2018
Merged
Bug fix: Don't use acorn just because file ends with comment#17goto-bus-stop merged 1 commit intobrowserify:masterfrom
goto-bus-stop merged 1 commit intobrowserify:masterfrom
Conversation
Macil
changed the title
Macil
changed the title
goto-bus-stop
approved these changes
Dec 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a file ends with a single-line comment, then in the quick-eval test, the "})()" appended to the end is commented out, the file unnecessarily fails the quick-eval test, and then the file is parsed with acorn.
When using browserify with sourcemaps enabled, it appears that every source string processed here ends with a single-line comment containing the sourcemap, so everything gets parsed by acorn here. I noticed this while using a profiler on a project's build.
This pull requests makes it so "\n})()" is appended to the end, preventing files ending in single-line comments from triggering an acorn parse.