Closed
Conversation
Collaborator
|
What are the implications? I’m 👍 on this since browserify is in need of more es6/import/export support. |
Member
Author
|
yeah, actually PRing this b/c i'm working on a node-compatible by default nothing changes. ES modules will still always fail the |
goto-bus-stop
added a commit
to goto-bus-stop/node-syntax-error
that referenced
this pull request
Jan 31, 2018
Uses acorn-node which is Acorn + some plugins and default options to match recent Node.js. This also changes the `opts` parameter to a simple pass thru, so that we only need to update acorn-node when a new `ecmaVersion` is supported in Node. If this is merged we don't need browserify#19 because you will already be able to pass the `sourceType`.
Merged
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows using
syntaxErroron ES modules source files.