Rails5.0.2#759
Merged
Merged
Conversation
…ng callbacks and removing deprecation warnings.
jtwohiou
commented
May 12, 2017
| model_params = params[model_form_name] | ||
| defaults.merge(model_params) | ||
| defaults.merge(model_params.to_unsafe_h) | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
This needs to be revisited
| filtered_params.delete(:controller) | ||
| filtered_params.merge!(:order => determine_order(filtered_params[:order], column_to_sort)) | ||
| polymorphic_path(engine_aware_path(content_type.model_class), filtered_params) | ||
| polymorphic_path(engine_aware_path(content_type.model_class), filtered_params.to_unsafe_h) |
Collaborator
Author
There was a problem hiding this comment.
This needs to be revisited.
| Given I am logged in as a Content Editor | ||
| And I view that Find Content Portlet in the page editor | ||
| Then I should see the content loaded by that Portlet | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
We should find a way to get this test back in.
| # | ||
| ActionController::Base.allow_rescue = false | ||
| $arel_silence_type_casting_deprecation=true | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Short term fix for arel deprecation warnings, will need to be revisited when creating the next bump.
|
|
||
| # Doing the SQL ourselves to avoid callbacks | ||
| ActiveRecord::Base.connection.execute(self.class.unscoped.where(self.class.arel_table[self.class.primary_key].eq(id)).arel.compile_update(quoted_attributes, id).to_sql) | ||
| my_class.where(:id=>id).update_all(update_params) |
Collaborator
Author
There was a problem hiding this comment.
This was causing lots of deprecation warnings so I moved it to active record. The update_all should avoid callbacks on the model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.