Install bytebuddy agent once per JVM #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move bytebuddy agent installation to a static block so that the installation only happens once per JVM. This ensures that the plugin works well with BUCK(and likewise) build systems where multiple javac compilation task is started parallely in the same JVM. Without this the JVM crashes undeterministically. This will also work well in gradle build system where once javac task runs per JVM
Owner
|
Hi @raviagarwal7, Thanks! The JNA dependency isn't unused - ByteBuddy will use it to emulate attachment on JVMs where emulation is not provided OOTB. Could you please revert that change? Happy to accept the PR once done! |
bsideup
approved these changes
Jun 18, 2021
Owner
|
@raviagarwal7 I reverted the JNA change and accepted your PR. Many thanks! I will release now, as I understand this is a blocker for you. |
Owner
|
Released as 0.4.1! |
Contributor
Author
|
thanks a lot @bsideup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move byte buddy agent installation to a static block so
that the installation only happens once per JVM.
This ensures that the plugin works well with BUCK(and likewise) build
systems where multiple javac compilation tasks are started parallelly in
the same JVM. Without this, the JVM crashes nondeterministically.
This will also work well in the Gradle build system where one javac
task runs per JVM.
Also remove the unused
net.java.dev.jna:jna:5.8.0dependency.